Re: [PATCH 1.2/2] mm: introduce memalloc_nofs

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 1.2/2] mm: introduce memalloc_nofs_{save,restore} API
From:	Michal Hocko <mhocko@xxxxxxxxxx>
Date:	Wed, 27 Apr 2016 22:30:10 +0200
Cc:	Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, linux-mm@xxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, Theodore Ts'o <tytso@xxxxxxx>, Chris Mason <clm@xxxxxx>, Jan Kara <jack@xxxxxxx>, ceph-devel@xxxxxxxxxxxxxxx, cluster-devel@xxxxxxxxxx, linux-nfs@xxxxxxxxxxxxxxx, logfs@xxxxxxxxx, xfs@xxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, reiserfs-devel@xxxxxxxxxxxxxxx, linux-ntfs-dev@xxxxxxxxxxxxxxxxxxxxx, linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx, linux-afs@xxxxxxxxxxxxxxxxxxx, LKML <linux-kernel@xxxxxxxxxxxxxxx>
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<20160427200927.GC22544@xxxxxxxxxxxxxx>
References:	<1461671772-1269-2-git-send-email-mhocko@xxxxxxxxxx> <1461758075-21815-1-git-send-email-mhocko@xxxxxxxxxx> <1461758075-21815-2-git-send-email-mhocko@xxxxxxxxxx> <20160427200927.GC22544@xxxxxxxxxxxxxx>
User-agent:	Mutt/1.5.24 (2015-08-30)

On Wed 27-04-16 22:09:27, Michal Hocko wrote:
[...]
> [   53.993480]   [<ffffffff810945e3>] mark_held_locks+0x5e/0x74
> [   53.993480]   [<ffffffff8109722c>] lockdep_trace_alloc+0xb2/0xb5
> [   53.993480]   [<ffffffff81174e56>] kmem_cache_alloc+0x36/0x2b0

Scratch that. I got it. It is the lockdep annotation which I got wrong
with my patch. I thought this was done much later in the slow path.
My head is burnt so I will get back to it tomorrow. The patch 1.1 should
be OK to go for XFS though because it doesn't really introduce anything
new.

Sorry about the noise!
-- 
Michal Hocko
SUSE Labs

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 2/2] mm, debug: report when GFP_NO{FS,IO} is used explicitly from memalloc_no{fs,io}_{save,restore} context, (continued) Re: [PATCH 2/2] mm, debug: report when GFP_NO{FS,IO} is used explicitly from memalloc_no{fs,io}_{save,restore} context, Dave Chinner Re: [PATCH 2/2] mm, debug: report when GFP_NO{FS,IO} is used explicitly from memalloc_no{fs,io}_{save,restore} context, Michal Hocko Re: [PATCH 2/2] mm, debug: report when GFP_NO{FS,IO} is used explicitly from memalloc_no{fs,io}_{save,restore} context, Dave Chinner [PATCH 1/2] mm: add PF_MEMALLOC_NOFS, Michal Hocko Re: [PATCH 1/2] mm: add PF_MEMALLOC_NOFS, Dave Chinner Re: [PATCH 1/2] mm: add PF_MEMALLOC_NOFS, Michal Hocko [PATCH 1.1/2] xfs: abstract PF_FSTRANS to PF_MEMALLOC_NOFS, Michal Hocko [PATCH 1.2/2] mm: introduce memalloc_nofs_{save,restore} API, Michal Hocko Re: [PATCH 1.2/2] mm: introduce memalloc_nofs_{save,restore} API, Michal Hocko Re: [PATCH 1.2/2] mm: introduce memalloc_nofs_{save,restore} API, Michal Hocko Re: [PATCH 1.2/2] mm: introduce memalloc_nofs_{save,restore} API, Michal Hocko <= Re: [PATCH 1.2/2] mm: introduce memalloc_nofs_{save,restore} API, Michal Hocko Re: [PATCH 1.1/2] xfs: abstract PF_FSTRANS to PF_MEMALLOC_NOFS, Andreas Dilger Re: [PATCH 1.1/2] xfs: abstract PF_FSTRANS to PF_MEMALLOC_NOFS, Michal Hocko Re: [PATCH 0/2] scop GFP_NOFS api, NeilBrown Re: [Cluster-devel] [PATCH 0/2] scop GFP_NOFS api, Steven Whitehouse Re: [Cluster-devel] [PATCH 0/2] scop GFP_NOFS api, NeilBrown Re: [PATCH 0/2] scop GFP_NOFS api, Michal Hocko Re: [PATCH 0/2] scop GFP_NOFS api, Dave Chinner Re: [PATCH 0/2] scop GFP_NOFS api, NeilBrown Re: [PATCH 0/2] scop GFP_NOFS api, Dave Chinner

Previous by Date:	Re: [PATCH 1.2/2] mm: introduce memalloc_nofs_{save,restore} API, Michal Hocko
Next by Date:	Re: [PATCH 1.2/2] mm: introduce memalloc_nofs_{save,restore} API, Michal Hocko
Previous by Thread:	Re: [PATCH 1.2/2] mm: introduce memalloc_nofs_{save,restore} API, Michal Hocko
Next by Thread:	Re: [PATCH 1.2/2] mm: introduce memalloc_nofs_{save,restore} API, Michal Hocko
Indexes:	[Date] [Thread] [Top] [All Lists]

Re: [PATCH 1.2/2] mm: introduce memalloc_nofs_{save,restore} API