| To: | Shyam Kaushik <shyam@xxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs: Abort intent log item in xfs_iflush() upon error to get buf |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Wed, 13 Apr 2016 07:16:19 +1000 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <5e9c99552ae829dce9eb574d72085323@xxxxxxxxxxxxxx> |
| References: | <23e35813cb097c7b15686852500cbf97@xxxxxxxxxxxxxx> <20160412082759.GI9088@dastard> <5e9c99552ae829dce9eb574d72085323@xxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Tue, Apr 12, 2016 at 11:10:13PM +0530, Shyam Kaushik wrote: > Hi Dave, > > Your patch needs a minor correction. > > At start of xfs_iflush() either we must initialize "bp = NULL" or else > xfs_imap_to_bp() when it hits an error need to set "*bpp = NULL". > Otherwise with your patch we are having an uninitialized bp that > corrupt_out is trying to do xfs_buf_relse(). Ok, I'll check that - I thought that xfs_trans_buf_read_map() was initialising it to zero appropriately, but obviously I missed something. Thanks for testing! Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 4/5] xfs: xfs_inode_free() isn't RCU safe, Dave Chinner |
|---|---|
| Next by Date: | Re: PAGE_CACHE_* removal in 4.6-rc3, Dave Chinner |
| Previous by Thread: | RE: [PATCH] xfs: Abort intent log item in xfs_iflush() upon error to get buf, Shyam Kaushik |
| Next by Thread: | RE: [PATCH] xfs: Abort intent log item in xfs_iflush() upon error to get buf, Shyam Kaushik |
| Indexes: | [Date] [Thread] [Top] [All Lists] |