xfs
[Top] [All Lists]

Re: XFS hung task in xfs_ail_push_all_sync() when unmounting FS after di

To: Shyam Kaushik <shyam@xxxxxxxxxxxxxxxxx>
Subject: Re: XFS hung task in xfs_ail_push_all_sync() when unmounting FS after disk failure/recovery
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 12 Apr 2016 08:47:55 +1000
Cc: Alex Lyakas <alex@xxxxxxxxxxxxxxxxx>, Brian Foster <bfoster@xxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1aa4e955d78e6932260fdfc55c83bb8e@xxxxxxxxxxxxxx>
References: <f049419a2ab10f8e3c4fef0e4f4ca1ba@xxxxxxxxxxxxxx> <20160322121922.GA53693@xxxxxxxxxxxxxxx> <232dd85fde11d4ef1625f070eabfd167@xxxxxxxxxxxxxx> <20160408224648.GD567@dastard> <CAOcd+r0s3FfahxaqfJKuZ_D+0FbUHaKqi8b_bwGbXekCN3w_oQ@xxxxxxxxxxxxxx> <20160411012127.GF567@dastard> <1aa4e955d78e6932260fdfc55c83bb8e@xxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Apr 11, 2016 at 08:22:14PM +0530, Shyam Kaushik wrote:
> Hi Dave,
> 
> Do you plan to post a patch for the bug you discovered in xfs_iflush() to
> goto abort_out when xfs_imap_to_bp() fails?

I'll get to it, but I can't do everything for everyone at once.

There is enough information in this thread that it shoul dbe
straight forward to write the two line patch to jump to the correct
error handling code, so the fact I haven't written the trivial
change yet should not be holding anyone up...

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>