xfs
[Top] [All Lists]

Re: [PATCH 18/19] mkfs: unit conversions are case insensitive

To: xfs@xxxxxxxxxxx
Subject: Re: [PATCH 18/19] mkfs: unit conversions are case insensitive
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Fri, 8 Apr 2016 10:51:56 -0500
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <CACj3i70EaLeECkmPUCUtpOeiMxWhgPPahs69yzWd0b_5Fy4sPQ@xxxxxxxxxxxxxx>
References: <1458818136-56043-1-git-send-email-jtulak@xxxxxxxxxx> <1458818136-56043-19-git-send-email-jtulak@xxxxxxxxxx> <57057B2A.3000100@xxxxxxxxxxx> <CACj3i736w-nnDzBDOiBf39cJ3AUHqeVL9_Y8EbUgaMa9S7PToA@xxxxxxxxxxxxxx> <5706FE56.7060308@xxxxxxxxxxx> <20160408010318.GA567@dastard> <CACj3i70EaLeECkmPUCUtpOeiMxWhgPPahs69yzWd0b_5Fy4sPQ@xxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.7.2
On 4/8/16 4:08 AM, Jan Tulak wrote:
> On Fri, Apr 8, 2016 at 3:03 AM, Dave Chinner <david@xxxxxxxxxxxxx 
> <mailto:david@xxxxxxxxxxxxx>>wrote:
> 

...

>     $ git grep ^cvtnum
>     estimate/xfs_estimate.c:cvtnum(char *s)
>     libxcmd/input.c:cvtnum(
>     mkfs/xfs_mkfs.c:cvtnum(
> 
> 
> âAh, I see. A nice trick. :-)
> 
> It might be good to merge the three functions, but I think it can
> wait for when this patchset is done - or there is always going to be
> something more to add...

Yeah, sorry, that was a tangent.  Just something to clean up some day.

-Eric

<Prev in Thread] Current Thread [Next in Thread>