| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 6/6] xfs: mark reclaimed inodes invalid earlier |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Thu, 7 Apr 2016 16:46:36 -0700 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1460072271-23923-7-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1460072271-23923-1-git-send-email-david@xxxxxxxxxxxxx> <1460072271-23923-7-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.24 (2015-08-30) |
> + spin_lock(&ip->i_flags_lock); > + ip->i_flags = XFS_IRECLAIM; > + ip->i_ino = 0; > + spin_unlock(&ip->i_flags_lock); It's just a tiny sniplet, but still duplicated from xfs_inode_free(). Maybe add another helper for this? Otherwise looks fine: Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 2/6] xfs: rename variables in xfs_iflush_cluster for clarity, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH] xfs/259: handle minimum block size more precisely, Christoph Hellwig |
| Previous by Thread: | [PATCH 6/6] xfs: mark reclaimed inodes invalid earlier, Dave Chinner |
| Next by Thread: | [PATCH 5/6] xfs: xfs_inode_free() isn't RCU safe, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |