| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: support RCU lookups for inline symlinks |
| From: | Christoph Hellwig <hch@xxxxxx> |
| Date: | Fri, 8 Apr 2016 01:21:35 +0200 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20160405215508.GH11238@dastard> |
| References: | <1458740935-31260-1-git-send-email-hch@xxxxxx> <20160405215508.GH11238@dastard> |
| User-agent: | Mutt/1.5.17 (2007-11-01) |
On Wed, Apr 06, 2016 at 07:55:08AM +1000, Dave Chinner wrote: > On Wed, Mar 23, 2016 at 02:48:51PM +0100, Christoph Hellwig wrote: > > Return the inline link body in the inode to support RCU mode lookups. > > The series doesn't appear to cause any regressions and the code > looks good, so I've added the missing xfs_setup_iops() call in > xfs_rename_alloc_whiteout() (patch 2), and converted dentry->d_inode > to d_inode(dentry) in patch 3 for consistency withe the rest of the > code and committed this series. Thanks. After some pondering I think we should setup the iops for the quota inodes as well - if we ever do something like vfs_getattr on them now that we're using VFS inode everywhere we'll need it. And I'd better be prepared for that than finding bugs after I've forgotten about all this. I'll send an incremental patch. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 14/19] mkfs: add string options to generic parsing, Eric Sandeen |
|---|---|
| Next by Date: | [PATCH 2/6] xfs: rename variables in xfs_iflush_cluster for clarity, Dave Chinner |
| Previous by Thread: | Re: support RCU lookups for inline symlinks, Dave Chinner |
| Next by Thread: | [ANNOUNCE] xfs: for-next branch updated to d8bdd04, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |