Re: [PATCH 18/19] mkfs: unit conversions are case insensitive

[Jan Tulak <jtulak@xxxxxxxxxx>]

On Wed, Apr 6, 2016 at 11:10 PM, Eric Sandeen <sandeen@xxxxxxxxxxx> wrote:

On 3/24/16 6:15 AM, jtulak@xxxxxxxxxx wrote:
> From: Jan Tulak <jtulak@xxxxxxxxxx>
>
> Solves the question "Should I use 10g or 10G?"

Might be nicer to do it like the cvtnum in libxcmd:

    c = tolower(*sp);
    switch (c) {
    case 'b':
        return i * blocksize;
...

âYeah, changed.

â

Â

(hm, why do we have 3 copies of cvtnum?)

âWhere? â

Ââ

â$ pwd

â/some/path/xfsprogs-dev

$ grep -r "cvtnum(size_t" . |grep -v "^Binary"

â./include/input.h:extern long long cvtnum(size_t blocksize, size_t sectorsize, char *s);

./io/init.h:extern void init_cvtnum(size_t *blocksize, size_t *sectsize);

--

Jan Tulak

jtulak@xxxxxxxxxxÂ/ jan@xxxxxxxx