Re: [PATCH] xfs: add missing break in xfs_parseargs()

[Eryu Guan <guaneryu@xxxxxxxxx>]

On Thu, Mar 31, 2016 at 05:13:03PM +0800, Eryu Guan wrote:
> Commit 2e74af0e1189 ("xfs: convert mount option parsing to tokens")
> missed a 'break;' in xfs_parseargs() which causes mount to fail with
> "-o pqnoenforce" option. xfs/050 catches this failure.
> 
> XFS (vda6): Super block does not support project and group quota together

Forgot to mention that it only fails for v4 xfs, but v5 xfs enables
group quota automatically in this case.

Thanks,
Eryu

> 
> Fixes: 2e74af0e1189 ("xfs: convert mount option parsing to tokens")
> Signed-off-by: Eryu Guan <guaneryu@xxxxxxxxx>
> ---
>  fs/xfs/xfs_super.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index d760934..361564e 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -350,6 +350,7 @@ xfs_parseargs(
>               case Opt_pqnoenforce:
>                       mp->m_qflags |= (XFS_PQUOTA_ACCT | XFS_PQUOTA_ACTIVE);
>                       mp->m_qflags &= ~XFS_PQUOTA_ENFD;
> +                     break;
>               case Opt_gquota:
>               case Opt_grpquota:
>                       mp->m_qflags |= (XFS_GQUOTA_ACCT | XFS_GQUOTA_ACTIVE |
> -- 
> 2.5.5
>