On Wed, Mar 30, 2016 at 10:41 PM, Mateusz Guzik <mguzik@xxxxxxxxxx> wrote:
> On Thu, Mar 31, 2016 at 07:26:55AM +1100, Dave Chinner wrote:
>> On Wed, Mar 30, 2016 at 04:35:07PM +0200, Mateusz Guzik wrote:
>> > Signed-off-by: Mateusz Guzik <mguzik@xxxxxxxxxx>
>> > ---
>> > fs/xfs/xfs_acl.c | 3 ++-
>> > 1 file changed, 2 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/fs/xfs/xfs_acl.c b/fs/xfs/xfs_acl.c
>> > index 2dad2b5..ce10c4c 100644
>> > --- a/fs/xfs/xfs_acl.c
>> > +++ b/fs/xfs/xfs_acl.c
>> > @@ -162,10 +162,11 @@ xfs_get_acl(struct inode *inode, int type)
>> > */
>> > if (error != -ENOATTR)
>> > acl = ERR_PTR(error);
>> > - return acl;
>> > + goto out;
>> > }
>> >
>> > acl = xfs_acl_from_disk(xfs_acl, len,
>> > XFS_ACL_MAX_ENTRIES(ip->i_mount));
>> > +out:
>> > kmem_free(xfs_acl);
>> > return acl;
>> > }
>>
>> Hi Mateusz,
>>
>> It looks like we've already fixed this problem - can you check
>> 4.6-rc1 and if the leak is still there post an updated patch?
>>
>
> The patch which introuced the bug is not present in 4.6-rc1.
The patch is on the work.acl branch of
git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git.
Thanks,
Andreas
|