| To: | Jens Axboe <axboe@xxxxxx>, linux-kernel@xxxxxxxxxxxxxxx |
|---|---|
| Subject: | [PATCH v1 3/8] block: mark 1st parameter of bvec_iter_advance as const |
| From: | Ming Lei <ming.lei@xxxxxxxxxxxxx> |
| Date: | Thu, 31 Mar 2016 00:17:12 +0800 |
| Cc: | linux-block@xxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Anton Altaparmakov <anton@xxxxxxxxxx>, xfs@xxxxxxxxxxx, Dave Chinner <david@xxxxxxxxxxxxx>, drbd-dev@xxxxxxxxxxxxxxxx, Philipp Reisner <philipp.reisner@xxxxxxxxxx>, Lars Ellenberg <lars.ellenberg@xxxxxxxxxx>, Boaz Harrosh <boaz@xxxxxxxxxxxxx>, Ming Lei <ming.lei@xxxxxxxxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1459354637-17415-1-git-send-email-ming.lei@xxxxxxxxxxxxx> |
| References: | <1459354637-17415-1-git-send-email-ming.lei@xxxxxxxxxxxxx> |
bvec_iter_advance() only writes the parameter of iterator,
so the base address of bvec can be marked as const safely.
Without the change, we can see compiling warning in the
following patch for implementing iterate_bvec(): lib/iov_iter.c
with bvec iterator.
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
Signed-off-by: Ming Lei <ming.lei@xxxxxxxxxxxxx>
---
include/linux/bvec_iter.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/linux/bvec_iter.h b/include/linux/bvec_iter.h
index 29c459d..9f0dcb2 100644
--- a/include/linux/bvec_iter.h
+++ b/include/linux/bvec_iter.h
@@ -45,7 +45,8 @@
.bv_offset = bvec_iter_offset((bvec), (iter)), \
})
-static inline void bvec_iter_advance(struct bio_vec *bv, struct bvec_iter
*iter,
+static inline void bvec_iter_advance(const struct bio_vec *bv,
+ struct bvec_iter *iter,
unsigned bytes)
{
WARN_ONCE(bytes > iter->bi_size,
--
1.9.1
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH v1 2/8] block: make 'struct bvec_iter' not depend on CONFIG_BLOCK, Ming Lei |
|---|---|
| Next by Date: | [PATCH v1 4/8] iov_iter: use bvec iterator to implement iterate_bvec(), Ming Lei |
| Previous by Thread: | Re: [PATCH v1 2/8] block: make 'struct bvec_iter' not depend on CONFIG_BLOCK, Ming Lei |
| Next by Thread: | [PATCH v1 4/8] iov_iter: use bvec iterator to implement iterate_bvec(), Ming Lei |
| Indexes: | [Date] [Thread] [Top] [All Lists] |