| To: | Ming Lei <ming.lei@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 7/8] block: drbd: avoid to use BIO_MAX_SIZE |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Tue, 29 Mar 2016 00:31:24 -0700 |
| Cc: | Jens Axboe <axboe@xxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Anton Altaparmakov <anton@xxxxxxxxxx>, xfs@xxxxxxxxxxx, Dave Chinner <david@xxxxxxxxxxxxx>, drbd-dev@xxxxxxxxxxxxxxxx, Philipp Reisner <philipp.reisner@xxxxxxxxxx>, Lars Ellenberg <lars.ellenberg@xxxxxxxxxx>, Boaz Harrosh <boaz@xxxxxxxxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1458627149-12988-8-git-send-email-ming.lei@xxxxxxxxxxxxx> |
| References: | <1458627149-12988-1-git-send-email-ming.lei@xxxxxxxxxxxxx> <1458627149-12988-8-git-send-email-ming.lei@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.24 (2015-08-30) |
On Tue, Mar 22, 2016 at 02:12:28PM +0800, Ming Lei wrote: > drbd is the only user of BIO_MAX_SIZE, so use BIO_MAX_PAGES > instead. That whole code block looks completely bogus to me, although your patch doesn't make it any worse. I/O size for a network protocol shouldn't dependend on the number of vectors in a kernel internal structure. Well, getting rid of BIO_MAX_SIZE is worth it, so: Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| Previous by Date: | Re: [PATCH 6/8] block: bio: remove BIO_MAX_SECTORS, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 8/8] block: bio: remove BIO_MAX_SIZE, Christoph Hellwig |
| Previous by Thread: | [PATCH 7/8] block: drbd: avoid to use BIO_MAX_SIZE, Ming Lei |
| Next by Thread: | Re: [PATCH 7/8] block: drbd: avoid to use BIO_MAX_SIZE, Lars Ellenberg |
| Indexes: | [Date] [Thread] [Top] [All Lists] |