On Fri, Mar 25, 2016 at 02:42:37PM -0700, Dan Williams wrote:
> That's their prerogative otherwise you are precluding an alternate
> handling of a dax_do_io() failure. Maybe a fs or upper layer can
> recover in a different manner than re-submit the I/O to the
> __blockdev_direct_IO path.
Let's keep the interface separate because they are, well separate.
There is a reason direct I/O falls back to buffered I/O by returning
and error if it can't handle it instead of handling all the magic.
I also really want to get rid of get_block as soon as possible for
DAX and direct I/O. For DAX that should actually be possible
really quickly, while direct I/O might take some time and will
be have to be gradual. So tighter integration of the two interface is
not just bad design, but actively harmful at this point in time.
|