| To: | Eryu Guan <guaneryu@xxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs: mute some sparse warnings |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Fri, 25 Mar 2016 11:07:19 -0700 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1458929042-23991-1-git-send-email-guaneryu@xxxxxxxxx> |
| References: | <1458929042-23991-1-git-send-email-guaneryu@xxxxxxxxx> |
| User-agent: | Mutt/1.5.24 (2015-08-30) |
> @@ -478,7 +478,8 @@ xfs_inode_item_unpin(
> STATIC uint
> xfs_inode_item_push(
> struct xfs_log_item *lip,
> - struct list_head *buffer_list)
> + struct list_head *buffer_list) __releases(&lip->li_ailp->xa_lock)
> + __acquires(&lip->li_ailp->xa_lock)
Can you move these down a bit? Something like:
struct list_head *buffer_list)
__releases(&lip->li_ailp->xa_lock)
__acquires(&lip->li_ailp->xa_lock)
{
?
Otherwise looks fine,
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] xfs: mute some sparse warnings, Eryu Guan |
|---|---|
| Next by Date: | Re: [PATCH 4/5] dax: use sb_issue_zerout instead of calling dax_clear_sectors, Dan Williams |
| Previous by Thread: | [PATCH] xfs: mute some sparse warnings, Eryu Guan |
| Next by Thread: | [PATCH v2] xfs: mute some sparse warnings, Eryu Guan |
| Indexes: | [Date] [Thread] [Top] [All Lists] |