On Wed, Mar 23, 2016 at 02:48:53PM +0100, Christoph Hellwig wrote:
> In the next patch we'll set up different inode operations for inline vs
> out of line symlinks, for that we need to make sure the flags are already
> set up properly.
....
> diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c
> index fb7dc61..f08d91c 100644
> --- a/fs/xfs/xfs_iops.c
> +++ b/fs/xfs/xfs_iops.c
> @@ -181,6 +181,8 @@ xfs_generic_create(
> }
> #endif
>
> + xfs_setup_iops(ip);
> +
> if (tmpfile)
> d_tmpfile(dentry, inode);
> else
> @@ -368,6 +370,8 @@ xfs_vn_symlink(
> if (unlikely(error))
> goto out_cleanup_inode;
>
> + xfs_setup_iops(cip);
> +
> d_instantiate(dentry, inode);
> xfs_finish_inode_setup(cip);
I think there are more places than this that need xfs_setup_iops()
calls - a quick look around makes me think they need to be paired
with every path that calls xfs_finish_inode_setup().
Cheers,
Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx
|