xfs
[Top] [All Lists]

Re: [PATCH 06/12] xfs/030: fix output on newer filesystems

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 06/12] xfs/030: fix output on newer filesystems
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 23 Mar 2016 14:40:40 +1100
Cc: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>, linux-ext4@xxxxxxxxxxxxxxx, fstests@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20160305202050.GF10245@xxxxxxxxxxxxx>
References: <20160305003717.28738.98818.stgit@xxxxxxxxxxxxxxxx> <20160305003756.28738.26362.stgit@xxxxxxxxxxxxxxxx> <20160305202050.GF10245@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Sat, Mar 05, 2016 at 12:20:50PM -0800, Christoph Hellwig wrote:
> Still fails for me:
> 
> --- tests/xfs/030.out 2016-03-03 07:55:58.556427678 +0000
> +++ /root/xfstests/results//xfs/030.out.bad   2016-03-05 20:20:17.561433837 
> +0000
> @@ -231,8 +231,6 @@
>  bad agbno AGBNO in agfl, agno 0
>  bad agbno AGBNO in agfl, agno 0
>  bad agbno AGBNO in agfl, agno 0
> -bad agbno AGBNO in agfl, agno 0
> -bad agbno AGBNO in agfl, agno 0

That's because the free lists are of different lengths on the
different fs configs. Not sure how best to handle it - maybe just
filter then entire bad agbno in agfl line out?

I'm going to commit the change anyway, as this is a separate issue
that needs to be solved.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>