| To: | Jens Axboe <axboe@xxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx |
|---|---|
| Subject: | [PATCH 3/8] block: mark 1st parameter of bvec_iter_advance as const |
| From: | Ming Lei <ming.lei@xxxxxxxxxxxxx> |
| Date: | Tue, 22 Mar 2016 14:12:24 +0800 |
| Cc: | linux-block@xxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Anton Altaparmakov <anton@xxxxxxxxxx>, xfs@xxxxxxxxxxx, Dave Chinner <david@xxxxxxxxxxxxx>, drbd-dev@xxxxxxxxxxxxxxxx, Philipp Reisner <philipp.reisner@xxxxxxxxxx>, Lars Ellenberg <lars.ellenberg@xxxxxxxxxx>, Boaz Harrosh <boaz@xxxxxxxxxxxxx>, Ming Lei <ming.lei@xxxxxxxxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1458627149-12988-1-git-send-email-ming.lei@xxxxxxxxxxxxx> |
| References: | <1458627149-12988-1-git-send-email-ming.lei@xxxxxxxxxxxxx> |
bvec_iter_advance() only writes the parameter of iterator,
so the base address of bvec can be marked as const safely.
Without the change, we can see compiling warning in the
following patch for implementing iterate_bvec(): lib/iov_iter.c
with bvec iterator.
Signed-off-by: Ming Lei <ming.lei@xxxxxxxxxxxxx>
---
include/linux/bvec_iter.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/linux/bvec_iter.h b/include/linux/bvec_iter.h
index cc43055..5798c21 100644
--- a/include/linux/bvec_iter.h
+++ b/include/linux/bvec_iter.h
@@ -49,7 +49,8 @@
.bv_offset = bvec_iter_offset((bvec), (iter)), \
})
-static inline void bvec_iter_advance(struct bio_vec *bv, struct bvec_iter
*iter,
+static inline void bvec_iter_advance(const struct bio_vec *bv,
+ struct bvec_iter *iter,
unsigned bytes)
{
WARN_ONCE(bytes > iter->bi_size,
--
1.9.1
|
| Previous by Date: | [PATCH 2/8] block: make 'struct bvec_iter' not depend on CONFIG_BLOCK, Ming Lei |
|---|---|
| Next by Date: | [PATCH 4/8] iov_iter: use bvec iterator to implement iterate_bvec(), Ming Lei |
| Previous by Thread: | Re: [PATCH 2/8] block: make 'struct bvec_iter' not depend on CONFIG_BLOCK, Christoph Hellwig |
| Next by Thread: | Re: [PATCH 3/8] block: mark 1st parameter of bvec_iter_advance as const, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |