xfs
[Top] [All Lists]

Re: [RFC PATCH 2/9] dm: add methods to set and get reserved space

To: xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx
Subject: Re: [RFC PATCH 2/9] dm: add methods to set and get reserved space
From: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
Date: Mon, 21 Mar 2016 13:17:26 +0100
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1458225037-24155-3-git-send-email-bfoster@xxxxxxxxxx>
Mail-followup-to: xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx
References: <1458225037-24155-1-git-send-email-bfoster@xxxxxxxxxx> <1458225037-24155-3-git-send-email-bfoster@xxxxxxxxxx>
User-agent: Mutt/1.5.24 (2015-08-30)
> +static int dm_blk_reserve_space(struct block_device *bdev, sector_t nr_sects)
> +{
> +
> +static int dm_blk_get_reserved_space(struct block_device *bdev,
> +                                  sector_t *nr_sects)
> +{

These two functions are almost identical, what about refactoring it to a single
function like dm_blk_reserved_space(), and maybe adding a flags argument, for
choosing between set/get reserved space? Or maybe just add the common parts of
these two functions inside a helper function or a macro?!

-- 
Carlos

<Prev in Thread] Current Thread [Next in Thread>