xfs
[Top] [All Lists]

Re: [PATCH] xfs/073: filter out finobt warning from mkfs.xfs

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs/073: filter out finobt warning from mkfs.xfs
From: Eryu Guan <eguan@xxxxxxxxxx>
Date: Wed, 16 Mar 2016 22:54:18 +0800
Cc: fstests@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20160316120416.GA18030@xxxxxxxxxxxxx>
References: <1458129204-31882-1-git-send-email-eguan@xxxxxxxxxx> <20160316120416.GA18030@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.24 (2015-08-30)
On Wed, Mar 16, 2016 at 05:04:16AM -0700, Christoph Hellwig wrote:
> On Wed, Mar 16, 2016 at 07:53:24PM +0800, Eryu Guan wrote:
> > When testing xfs/073 with MKFS_OPTIONS="-m crc=1,finobt=1" set, it fails
> > due to extra warning about disabling finobt feature:
> > 
> >  +warning: finobt not supported without CRC support, disabled.
> > 
> > Because xfs/073 disables crc unconditionally and finobt can not be
> > enabled either.
> 
> How about explicitly disabling finobt as well?

I think that's a cleaner way to fix it. Just that some extra work is
needed to let the test pass with old mkfs.xfs without metadata suport.

Will send v2 shortly. Thanks for the review!

Eryu

<Prev in Thread] Current Thread [Next in Thread>