Re: [PATCH 3/4] xfs: remove put_value from attr ->put

xfs

Re: [PATCH 3/4] xfs: remove put_value from attr ->put_listent context

To:	Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject:	Re: [PATCH 3/4] xfs: remove put_value from attr ->put_listent context
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Tue, 15 Mar 2016 00:56:07 -0700
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<56E342BD.2030103@xxxxxxxxxxx>
References:	<56E3425E.40509@xxxxxxxxxx> <56E342BD.2030103@xxxxxxxxxxx>
User-agent:	Mutt/1.5.24 (2015-08-30)

On Fri, Mar 11, 2016 at 04:12:13PM -0600, Eric Sandeen wrote:
> The put_value context member is never set; remove it
> and the conditional test in xfs_attr3_leaf_list_int().

Looks fine,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

(although this should probably go along with the previous patch)

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/4] xfs: rework the attr ->put_listent code a bit, Eric Sandeen [PATCH 1/4] xfs: only return -errno or success from attr ->put_listent, Eric Sandeen Re: [PATCH 1/4] xfs: only return -errno or success from attr ->put_listent, Christoph Hellwig [PATCH 2/4] xfs: don't pass value into attr ->put_listent, Eric Sandeen Re: [PATCH 2/4] xfs: don't pass value into attr ->put_listent, Christoph Hellwig [PATCH 3/4] xfs: remove put_value from attr ->put_listent context, Eric Sandeen Re: [PATCH 3/4] xfs: remove put_value from attr ->put_listent context, Christoph Hellwig <= [PATCH 4/4] xfs: collapse cases in xfs_attr3_leaf_list_int, Eric Sandeen Re: [PATCH 4/4] xfs: collapse cases in xfs_attr3_leaf_list_int, Christoph Hellwig

Previous by Date:	Re: [PATCH 2/4] xfs: don't pass value into attr ->put_listent, Christoph Hellwig
Next by Date:	Re: [PATCH 4/4] xfs: collapse cases in xfs_attr3_leaf_list_int, Christoph Hellwig
Previous by Thread:	[PATCH 3/4] xfs: remove put_value from attr ->put_listent context, Eric Sandeen
Next by Thread:	[PATCH 4/4] xfs: collapse cases in xfs_attr3_leaf_list_int, Eric Sandeen
Indexes:	[Date] [Thread] [Top] [All Lists]