| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 12/12] block: test fallocate for block devices |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Tue, 15 Mar 2016 14:41:48 +1100 |
| Cc: | "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>, linux-ext4@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, fstests@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20160305182508.GA25528@xxxxxxxxxxxxx> |
| References: | <20160305003717.28738.98818.stgit@xxxxxxxxxxxxxxxx> <20160305003837.28738.49794.stgit@xxxxxxxxxxxxxxxx> <20160305182508.GA25528@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Sat, Mar 05, 2016 at 10:25:08AM -0800, Christoph Hellwig wrote: > I'm not sure xfstests is the right fit, as it does not test a file > system, but rather block devices. > > If people think it should go into xfstests we should at least not > add it to the default group, but just to a new bdev group. I think it's the right place to test it - we have all the infrastructure available to do it (i.e. xfs_io and various block devices) and we really need to make sure this stuff works, especially if we start to write filesystem code that depends on correct behaviour... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| Previous by Date: | Re: [XFSTESTS v4 0/4] Richacl tests, Dave Chinner |
|---|---|
| Next by Date: | [ANNOUNCE] xfsprogs: v4.5.0 released, Dave Chinner |
| Previous by Thread: | Re: [PATCH 12/12] block: test fallocate for block devices, Darrick J. Wong |
| Next by Thread: | Re: [PATCH 12/12] block: test fallocate for block devices, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |