| To: | Alex Lyakas <alex@xxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: xfs resize: primary superblock is not updated immediately |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Mon, 7 Mar 2016 07:49:38 +1100 |
| Cc: | Christoph Hellwig <hch@xxxxxxxxxxxxx>, Danny Shavit <danny@xxxxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <CAOcd+r1b_9yhBtaBGHeMY7eOUyp1pO=DRbq0z2B1ojyiO-8t=A@xxxxxxxxxxxxxx> |
| References: | <CAOcd+r1XY2kcp+qJ=mPOAQSmb90QUnLfmT3-FkMjQN_+Ejmt8A@xxxxxxxxxxxxxx> <20160222235628.GK25832@dastard> <D5578D3E98EE48B88EA9A1126B671155@alyakaslap> <20160223225926.GN25832@dastard> <BC0CC25E00CE4CEDA1FFDFC0A2F38742@alyakaslap> <20160229211628.GK29057@dastard> <20160301072011.GF30721@dastard> <E965894DE8D542788CCE98F72C218C05@alyakaslap> <20160303213108.GQ30721@dastard> <CAOcd+r1b_9yhBtaBGHeMY7eOUyp1pO=DRbq0z2B1ojyiO-8t=A@xxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Sun, Mar 06, 2016 at 11:46:58AM +0200, Alex Lyakas wrote: > Hello Dave, > > On Thu, Mar 3, 2016 at 11:31 PM, Dave Chinner <david@xxxxxxxxxxxxx> wrote: > > On Thu, Mar 03, 2016 at 11:18:43AM +0200, Alex Lyakas wrote: > >> Hello Dave, > >> Thanks for the patch! I confirm that it fixes the scenario. > >> > >> At [1] please find all the blknos that are being used during the log > >> recovery (if that's of any interest). > > .... > >> Mar 3 11:17:41 vc-00-00-350-dev kernel: [ 68.129739] > >> _xfs_buf_find: blkno=200705 eofs=204800 >m_sb.sb_dblocks=25600 > >> Mar 3 11:17:41 vc-00-00-350-dev kernel: [ 68.129746] > >> _xfs_buf_find: blkno=200705 eofs=204800 >m_sb.sb_dblocks=25600 > > > > Where is the warning that this block is out of range? > Perhaps you are being confused by the ">" mark that appears in the > prints? This was definitely added by mistake, it appears on every > print. I apologize for that. > If not, then my understanding is that 200705 is still less than > 204800, so this block number is not out of range. And since we have > added the new pag structure, the issue is now fixed. Sorry, I misread it as 200480, not 204800. My fault, too much to do, brain mostly fried by other stuff. So the patch works. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: xfs resize: primary superblock is not updated immediately, Eric Sandeen |
|---|---|
| Next by Date: | [PATCH 6/6] xfs: pad xfs_attr_leaf_name_remote to avoid tripping on m68k, Dave Chinner |
| Previous by Thread: | Re: xfs resize: primary superblock is not updated immediately, Eric Sandeen |
| Next by Thread: | Re: generic/320 triggers "list_add attempted on force-poisoned entry" warning on XFS, Eryu Guan |
| Indexes: | [Date] [Thread] [Top] [All Lists] |