xfs
[Top] [All Lists]

Re: [PATCH] xfs: fix computation of inode btree maxlevels

To: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
Subject: Re: [PATCH] xfs: fix computation of inode btree maxlevels
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 2 Mar 2016 01:45:20 -0800
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20160302050930.GD27973@xxxxxxxxxxxxxxxx>
References: <20160302050930.GD27973@xxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.24 (2015-08-30)
On Tue, Mar 01, 2016 at 09:09:30PM -0800, Darrick J. Wong wrote:
> Commit 88740da18[1] introduced a function to compute the maximum
> height of the inode btree back in 1994.  Back then, apparently, the
> freespace and inode btrees shared the same geometry; however, it has
> long since been the case that the inode and freespace btrees have
> different record and key sizes.

I think that's always been the case, so this has been buggy since
day one.  Congrat for gfinding one of the probably oldest bugs so far!

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>