Re: [PATCH 3/3] xfs: borrow indirect blocks from freed extent when avail

xfs

Re: [PATCH 3/3] xfs: borrow indirect blocks from freed extent when avail

To:	Brian Foster <bfoster@xxxxxxxxxx>
Subject:	Re: [PATCH 3/3] xfs: borrow indirect blocks from freed extent when available
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Tue, 1 Mar 2016 05:00:18 -0800
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1456756170-51248-4-git-send-email-bfoster@xxxxxxxxxx>
References:	<1456756170-51248-1-git-send-email-bfoster@xxxxxxxxxx> <1456756170-51248-4-git-send-email-bfoster@xxxxxxxxxx>
User-agent:	Mutt/1.5.24 (2015-08-30)

I've been wrapping my head around this since yersterday..

It looks reasonable, but I'd be much more comfortable if you could
split this into two patches:

 - one to just factor out a helper to update the temp and temp2
   values (great variable names while we're at it..  not your fault,
   though)
 - one to actually change the algorithm used.

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 3/3] xfs: borrow indirect blocks from freed extent when available, Christoph Hellwig <= Re: [PATCH 3/3] xfs: borrow indirect blocks from freed extent when available, Brian Foster

Previous by Date:	Re: [PATCH RFC 1/3] xfs: debug mode forced buffered write failure, Christoph Hellwig
Next by Date:	Re: futher writeback updates, Christoph Hellwig
Previous by Thread:	Re: [PATCH RFC 1/3] xfs: debug mode forced buffered write failure, Christoph Hellwig
Next by Thread:	Re: [PATCH 3/3] xfs: borrow indirect blocks from freed extent when available, Brian Foster
Indexes:	[Date] [Thread] [Top] [All Lists]