xfs
[Top] [All Lists]

Re: [PATCH] xfs_io: Prevent devide by zero from {pread,pwrite}_random

To: Dmitry Monakhov <dmonakhov@xxxxxxxxxx>
Subject: Re: [PATCH] xfs_io: Prevent devide by zero from {pread,pwrite}_random
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 1 Mar 2016 04:09:11 -0800
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <8760xc3jfu.fsf@xxxxxxxxxx>
References: <8760xc3jfu.fsf@xxxxxxxxxx>
User-agent: Mutt/1.5.24 (2015-08-30)
On Thu, Feb 25, 2016 at 07:20:53PM +0400, Dmitry Monakhov wrote:
> 
> Math is wrong if range requested is less or equals to block size
> 
> xfs_io -c 'pwrite -b 4k 8k 4k -R' \
>        -c 'pread -b 4k  4k 4k -R' -f file
> 
> Signed-off-by: Dmitry Monakhov <dmonakhov@xxxxxxxxxx>

Looks fine,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Are we going to see a new testcase that relies on this soon? :)

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH] xfs_io: Prevent devide by zero from {pread,pwrite}_random, Christoph Hellwig <=