xfs
[Top] [All Lists]

[PATCH] xfs: remove impossible condition

To: linux-kernel@xxxxxxxxxxxxxxx
Subject: [PATCH] xfs: remove impossible condition
From: Luis de Bethencourt <luisbg@xxxxxxxxxxxxxxx>
Date: Thu, 25 Feb 2016 12:43:57 +0000
Cc: xfs@xxxxxxxxxxx, david@xxxxxxxxxxxxx, bfoster@xxxxxxxxxx, sandeen@xxxxxxxxxxx, namjae.jeon@xxxxxxxxxxx, cmaiolino@xxxxxxxxxx, darrick.wong@xxxxxxxxxx, billodo@xxxxxxxxxx, Luis de Bethencourt <luisbg@xxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
bp_release is set to 0 just before the breakpoint of the for loop before
the conditional check (in line 458). The other breakpoint is a goto that
skips the dead code.

Addresses-Coverity-Id: 102338

Signed-off-by: Luis de Bethencourt <luisbg@xxxxxxxxxxxxxxx>
---

Hi,

Thanks for reviewing this :)

Luis

 fs/xfs/libxfs/xfs_bmap.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
index 6a05166..1171795 100644
--- a/fs/xfs/libxfs/xfs_bmap.c
+++ b/fs/xfs/libxfs/xfs_bmap.c
@@ -477,10 +477,7 @@ xfs_bmap_check_leaf_extents(
                }
                block = XFS_BUF_TO_BLOCK(bp);
        }
-       if (bp_release) {
-               bp_release = 0;
-               xfs_trans_brelse(NULL, bp);
-       }
+
        return;
 
 error0:
-- 
2.5.1

<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH] xfs: remove impossible condition, Luis de Bethencourt <=