Re: [PATCH 2/3] xfs: better xfs_trans_alloc interface

[Christoph Hellwig <hch@xxxxxx>]

On Thu, Feb 18, 2016 at 09:04:36AM +1100, Dave Chinner wrote:
> I've considered doing this removal myself in the past - doing
> somethign like embedding the return address of the
> xfs-trans_reserve() call in the ticket that is allocated tells us
> exactly where the call was made. This can be printed with %pS, and
> that gives us the function (and location in the function) the
> reservation was made. Hence we solve the problem of not
> knowing which call path triggered the problem.
> 
> Hence I don't think we actually need to the type in every function
> call.

This brings up a question:  do we care about the type of the transaction,
or the caller?  The existing types were rather confused about that.
If it's the transaction type we could simply add a name field to
struct xfs_trans_res, if we care about caller the trick from Dave
should do the job.

> 
> Cheers,
> 
> Dave.
> -- 
> Dave Chinner
> david@xxxxxxxxxxxxx
---end quoted text---