xfs
[Top] [All Lists]

Re: richacl(7) man page review comments

To: Andreas Gruenbacher <agruenba@xxxxxxxxxx>
Subject: Re: richacl(7) man page review comments
From: "Michael Kerrisk (man-pages)" <mtk.manpages@xxxxxxxxx>
Date: Sun, 21 Feb 2016 22:01:25 +0100
Cc: mtk.manpages@xxxxxxxxx, "J. Bruce Fields" <bfields@xxxxxxxxxxxx>, linux-ext4 <linux-ext4@xxxxxxxxxxxxxxx>, XFS Developers <xfs@xxxxxxxxxxx>, lkml <linux-kernel@xxxxxxxxxxxxxxx>, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>, Linux NFS Mailing List <linux-nfs@xxxxxxxxxxxxxxx>, linux-cifs@xxxxxxxxxxxxxxx, Linux API <linux-api@xxxxxxxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Anna Schumaker <anna.schumaker@xxxxxxxxxx>, Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx>, Jeff Layton <jlayton@xxxxxxxxxxxxxxx>, Andreas Dilger <adilger@xxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=R2kC1blT7vVYZD39HmEkXFLwM0cqWWz1qBz3ytJXvyM=; b=auguerSt2wIadL5xCh3TIv8rMNq7obUd1RPfbzc/jXDwUwXvm7d19/nZlIruNqZs/z t80Ves0BQtymLFeVH7d5r41A/wT9xKXOLbm8REVRhaSuG3RoVkLE+/7vIkHpiZwYfQ/i WQpMeqBDI1pZykRFkYKAQ+PGcOkcUpr7BHdMazN5X2GcpHLzctW6V6jQikbxziF+zOP3 clmlZVgQHM5SBNkrWUDyEXOlWVfGoKKh3i97JEI33drsM9CXGvSFTqKHR//0fnlnlI2B qLyK8AHQ8WNbH0suWatvVp9o398gwHguNR5KlOqA+kxkmJlbHOL3jlqkqEyFG71FMefN V9cA==
In-reply-to: <CAHc6FU4CCrcrA6=oCiq2A5rGd9CCGELaTZq6tGpmd2jcV_Zp4A@xxxxxxxxxxxxxx>
References: <56B770B6.7040803@xxxxxxxxx> <56B77262.7090107@xxxxxxxxx> <CAHc6FU5__xbKm4mg8+fK_ZW5ZYsDoQcYBBvQg573Eq4ERDsROw@xxxxxxxxxxxxxx> <56C0F23C.7030902@xxxxxxxxx> <CAHc6FU4CCrcrA6=oCiq2A5rGd9CCGELaTZq6tGpmd2jcV_Zp4A@xxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0
On 02/20/2016 05:37 PM, Andreas Gruenbacher wrote:
> Hi Michael,
> 
> thanks again for all the feedback. I've followed all your suggestions;
> again, please see the github repo for the latest version:
> 
>   https://github.com/andreas-gruenbacher/richacl
> 
> On Sun, Feb 14, 2016 at 10:31 PM, Michael Kerrisk (man-pages)
> <mtk.manpages@xxxxxxxxx> wrote:
>> Hi Andreas,
>>
>> Here's a few more comments on the current richacl(7) page
>> that I fetched from the git repo.
>>

[...]

>>> .HP
>>> .BR dir_inherit "\ (" d ):
>>> The entry is inheritable for directories.
>>
>> "When this flag appears in the ACL entry of a directory, then that entry is
>> inherited by new subdirectories created in the directory."
>>
>> Is that text that I propose correct?
> 
> It's not entirely wrong, but only a small part of the truth. Entries
> are inherited such that the permissions in file_inherit entries become
> effective for access checking for new files, and the permissions in
> dir_inherit entries become effective for access checking for new
> directories, recursively.
> 
> Your feedback prompted me to look into the inheritance flag
> computation more closely once again, and I found bugs. The steps of
> the algorithm are explained in the section "Permissions at
> file-creation time", by the way.

Hmmm... writing and refining documentation helps find code bugs. 
Who knew? :-)

Cheers,

Michael

-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

<Prev in Thread] Current Thread [Next in Thread>