Re: [PATCH 12/15] xfs: use vfs inode nlink field everywhere

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 12/15] xfs: use vfs inode nlink field everywhere
From:	Dave Chinner <david@xxxxxxxxxxxxx>
Date:	Wed, 17 Feb 2016 18:49:53 +1100
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<20160217073506.GC16363@xxxxxxxxxxxxx>
References:	<1455693652-3899-1-git-send-email-david@xxxxxxxxxxxxx> <1455693652-3899-13-git-send-email-david@xxxxxxxxxxxxx> <20160217073506.GC16363@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Tue, Feb 16, 2016 at 11:35:06PM -0800, Christoph Hellwig wrote:
> > index 685c7a7..1408be3 100644
> > --- a/libxfs/libxfs_api_defs.h
> > +++ b/libxfs/libxfs_api_defs.h
> > @@ -108,4 +108,8 @@
> >  
> >  #define xfs_verify_cksum           libxfs_verify_cksum
> >  
> > +/* inode link counts */
> > +#define set_nlink(inode, nlink)    ({ (inode)->i_nlink = (nlink); })
> > +#define inc_nlink(inode)   (inode)->i_nlink++
> 
> Can we defines these as inlines?

I'll probably have to move them somewhere else for that.
include/xfs_inode.h will probably work.

> 
> > +           ip->i_vnode.i_nlink++;          /* account for . */
> 
> Shouldn't we use VFS_I() like everywhere else?

inc_nlink(), too. I forgot to go back and change it when I decided
on adding the wrapper.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 04/15] xfs: move buffer invalidation to xfs_btree_free_block, (continued) [PATCH 04/15] xfs: move buffer invalidation to xfs_btree_free_block, Dave Chinner [PATCH 06/15] xfs: RT bitmap and summary buffers are not typed, Dave Chinner [PATCH 01/15] xfs: wire up Q_XGETNEXTQUOTA / get_nextdqblk, Dave Chinner Re: [PATCH 01/15] xfs: wire up Q_XGETNEXTQUOTA / get_nextdqblk, Christoph Hellwig [PATCH 03/15] xfs: factor btree block freeing into a helper, Dave Chinner [PATCH 08/15] xfs: introduce inode log format object, Dave Chinner [PATCH 05/15] xfs: remove unused function definitions, Dave Chinner [PATCH 10/15] xfs: cull unnecessary icdinode fields, Dave Chinner [PATCH 12/15] xfs: use vfs inode nlink field everywhere, Dave Chinner Re: [PATCH 12/15] xfs: use vfs inode nlink field everywhere, Christoph Hellwig Re: [PATCH 12/15] xfs: use vfs inode nlink field everywhere, Dave Chinner <= [PATCH 15/15] xfs: mode di_mode to vfs inode, Dave Chinner [PATCH 09/15] xfs: remove timestamps from incore inode, Dave Chinner Re: [PATCH 09/15] xfs: remove timestamps from incore inode, Brian Foster Re: [PATCH 09/15] xfs: remove timestamps from incore inode, Darrick J. Wong [PATCH 07/15] xfs: RT bitmap and summary buffers need verifiers, Dave Chinner [PATCH 14/15] xfs: move di_changecount to VFS inode, Dave Chinner [PATCH 11/15] xfs: move v1 inode conversion to xfs_inode_from_disk, Dave Chinner Re: [PATCH 11/15] xfs: move v1 inode conversion to xfs_inode_from_disk, Christoph Hellwig Re: [PATCH 11/15] xfs: move v1 inode conversion to xfs_inode_from_disk, Dave Chinner Re: [PATCH 11/15] xfs: move v1 inode conversion to xfs_inode_from_disk, Dave Chinner

Previous by Date:	Re: [PATCH 11/15] xfs: move v1 inode conversion to xfs_inode_from_disk, Dave Chinner
Next by Date:	Re: [PATCH 00/15] xfsprogs: libxfs kernel sync to 4.6-for-next, Christoph Hellwig
Previous by Thread:	Re: [PATCH 12/15] xfs: use vfs inode nlink field everywhere, Christoph Hellwig
Next by Thread:	[PATCH 15/15] xfs: mode di_mode to vfs inode, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]