xfs
[Top] [All Lists]

Re: [PATCH 11/15] xfs: move v1 inode conversion to xfs_inode_from_disk

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 11/15] xfs: move v1 inode conversion to xfs_inode_from_disk
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 16 Feb 2016 23:32:04 -0800
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1455693652-3899-12-git-send-email-david@xxxxxxxxxxxxx>
References: <1455693652-3899-1-git-send-email-david@xxxxxxxxxxxxx> <1455693652-3899-12-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.24 (2015-08-30)
On Wed, Feb 17, 2016 at 06:20:48PM +1100, Dave Chinner wrote:
> +
> +     sbversion |= XFS_SB_VERSION_NLINKBIT;
> +     setlink_inode(id, be32_to_cpu(dip->di_nlink), type == DBM_DIR, 
> security);
> +

So we always convert to v2 inodes here.  Given that's it's xfs_check
it's only in-core so harmless, but a comment here might be useful.

<Prev in Thread] Current Thread [Next in Thread>