xfs
[Top] [All Lists]

Re: [PATCH 12/32] dio: unwritten conversion bug tests

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 12/32] dio: unwritten conversion bug tests
From: Theodore Ts'o <tytso@xxxxxxx>
Date: Fri, 12 Feb 2016 10:22:31 -0500
Cc: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>, linux-btrfs@xxxxxxxxxxxxxxx, fstests@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=thunk.org; s=ef5046eb; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=vHtVAfsBnE0VYB0tf37z7ify1E7bWUYfkoDMu2RdJoM=; b=DPWX+TiI7AzQ4z5Cg57fIFtyDawdb0QR39QDexokFHLDE7K8fDgKzhZRcIm5NVP0gIACETrkAuKQzsndFDpcnNgk+v/r6JmH/XImY5I8mbQ/YV7kmgzGw9wo9m1v6Iax74zDm3rENlWULNxTVQTaGfgPjGBepswk73XLeel7IN0=;
In-reply-to: <20160212035253.GX14668@dastard>
References: <20160211233916.2202.40961.stgit@xxxxxxxxxxxxxxxx> <20160211234037.2202.93885.stgit@xxxxxxxxxxxxxxxx> <20160212035253.GX14668@dastard>
User-agent: Mutt/1.5.24 (2015-08-30)
On Fri, Feb 12, 2016 at 02:52:53PM +1100, Dave Chinner wrote:
> On Thu, Feb 11, 2016 at 03:40:37PM -0800, Darrick J. Wong wrote:
> > Check that we don't expose old disk contents when a directio write to
> > an unwritten extent fails due to IO errors.  This primarily affects
> > XFS and ext4.
> > 
> > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> 
> aiocp.c: In function 'main':
> aiocp.c:407:1: warning: format '%d' expects argument of type 'int', but 
> argument 3 has type 'off_t' [-Wformat=]
>  printf("tocopy=%d len=%d blk=%d\n", tocopy, length, aio_blksize);
>  ^
> 
> Followup patch is fine, I'll commit as is.

Dave, given that Darrick's patches is going to cause more
_scratch_mount occurences, how quickly do you plan to commit his
patchset?  Should I wait until he makes his change before I do the
s/_scratch_mount/_scratch_cycle_mount/ change?  Should I make that
change, and let you fix it up the commit?

Thanks,

                                        - Ted

<Prev in Thread] Current Thread [Next in Thread>