Re: [PATCH 6/6] xfs: don't chain ioends during writepage submission

xfs

Re: [PATCH 6/6] xfs: don't chain ioends during writepage submission

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 6/6] xfs: don't chain ioends during writepage submission
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Fri, 12 Feb 2016 01:36:07 -0800
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1455173146-19535-7-git-send-email-david@xxxxxxxxxxxxx>
References:	<1455173146-19535-1-git-send-email-david@xxxxxxxxxxxxx> <1455173146-19535-7-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.24 (2015-08-30)

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Tiny nitpick below:

>  out_error:
>       /*

Now that the code below this label is more than just error handling
it might make sense to rename it to just 'out'.

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/6 v5] xfs: get rid of xfs_cluster_write(), Dave Chinner [PATCH 2/6] xfs: remove xfs_cancel_ioend, Dave Chinner Re: [PATCH 2/6] xfs: remove xfs_cancel_ioend, Christoph Hellwig [PATCH 1/6] xfs: remove nonblocking mode from xfs_vm_writepage, Dave Chinner [PATCH 3/6] xfs: Introduce writeback context for writepages, Dave Chinner [PATCH 5/6] xfs: factor mapping out of xfs_do_writepage, Dave Chinner [PATCH 6/6] xfs: don't chain ioends during writepage submission, Dave Chinner Re: [PATCH 6/6] xfs: don't chain ioends during writepage submission, Christoph Hellwig <= [PATCH 4/6] xfs: xfs_cluster_write is redundant, Dave Chinner

Previous by Date:	Re: [PATCH 2/6] xfs: remove xfs_cancel_ioend, Christoph Hellwig
Next by Date:	Re: [PATCH 2/2 v3] xfs_repair: new secondary superblock search method, Eric Sandeen
Previous by Thread:	[PATCH 6/6] xfs: don't chain ioends during writepage submission, Dave Chinner
Next by Thread:	[PATCH 4/6] xfs: xfs_cluster_write is redundant, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]