| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2/8] xfs: remove xfs_cancel_ioend |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Thu, 11 Feb 2016 07:14:25 -0800 |
| Cc: | Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20160211002137.GR14668@dastard> |
| References: | <1455094043-9694-1-git-send-email-david@xxxxxxxxxxxxx> <1455094043-9694-3-git-send-email-david@xxxxxxxxxxxxx> <20160210112800.GA15221@xxxxxxxxxxxxx> <20160211002137.GR14668@dastard> |
| User-agent: | Mutt/1.5.24 (2015-08-30) |
On Thu, Feb 11, 2016 at 11:21:37AM +1100, Dave Chinner wrote: > I'll propagate it through where it makes sense. If we alrady have an > error, then we aren't going to call xfs_setfilesize_trans_alloc() > anyway, so checking the return value only matters in the non-error > cases. Oh, I missed that we don't care about the failure case. Maybe we should just call xfs_setfilesize_trans_alloc instead, and just move the conditionals to it so that it's a no-op if no transaction is needed? |
| Previous by Date: | Re: [PATCH 0/8 v4] xfs: get rid of xfs_cluster_write, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH v2 2/2] dax: move writeback calls into the filesystems, Dan Williams |
| Previous by Thread: | Re: [PATCH 2/8] xfs: remove xfs_cancel_ioend, Dave Chinner |
| Next by Thread: | Re: [PATCH 2/8] xfs: remove xfs_cancel_ioend, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |