Re: [PATCH 3/8] xfs: Introduce writeback context for writepages

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

> +     struct xfs_writepage_ctx wpc = {
> +             .io_type = XFS_IO_OVERWRITE,
> +     };
> +     int                     ret;
> +
> +     ret = xfs_do_writepage(page, wbc, &wpc);
> +     return xfs_writepage_submit(&wpc, wbc, ret);
> +}
> +
> +STATIC int
>  xfs_vm_writepages(
>       struct address_space    *mapping,
>       struct writeback_control *wbc)
>  {
> +     struct xfs_writepage_ctx wpc = {
> +             .io_type = XFS_IO_OVERWRITE,
> +     };

Shouldn't we start out with an invalid (0) state, and just move
the actual states up to start from 1?

Otherwise looks fine,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>