xfs
[Top] [All Lists]

Re: [PATCH 0/8 v4] xfs: get rid of xfs_cluster_write

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 0/8 v4] xfs: get rid of xfs_cluster_write
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 10 Feb 2016 01:05:06 -0800
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1455094043-9694-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1455094043-9694-1-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.24 (2015-08-30)
Seems like only 4 patches made it through..

On Wed, Feb 10, 2016 at 07:47:15PM +1100, Dave Chinner wrote:
> 
> Hi folks,
> 
> This is the 4th version of this series to followup on review
> comments from Brian and Christoph. There are three new patches in
> this series. Patch 2/8 is split out from patch 3/8 to document the
> removal of the ioend cancelling code, spearate from the introduction
> of the writepage context. Patches 7 and 8 are new patches (as in the
> first time I've posted them) to demonstrate how to remove the IO
> completion dependency on recording the bufferehads attached to the
> ioend. This is the first step in removing bufferheads from the
> writepage IO path - these are FYI patches, not patches I want to
> have committed immediately.
> 
> The changes all run through xfstests on 4k and 1k block size
> filesystems fine, and I think i addressed all the review comments.
> Patch 6/8 changed enough that I removed Brian's reviewed-by from it
> and so it will need to be looked at completely again.
> 
> -Dave.
> 
> Version 4:
> - split xfs_ioend_cancel removal into it's own patch (patch 2)
> - cleaned up submission of ioends to be consistent w.r.t. success
>   and error paths (patch 3)
> - made variables names less verbose (patch 6)
> - got rid of xfs_writepage_submit() (patch 6)
> - use a struct list_head for ioend chaining (patch 6)
> - consolidated ioend submission paths to use common code (patch 6)
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
---end quoted text---

<Prev in Thread] Current Thread [Next in Thread>