Re: [PATCH] xfsprogs: guard fsxattr definition for newer kernels

[Dave Chinner <david@xxxxxxxxxxxxx>]

On Tue, Feb 09, 2016 at 11:40:57AM -0600, Eric Sandeen wrote:
> After 334e580,
> fs: XFS_IOC_FS[SG]SETXATTR to FS_IOC_FS[SG]ETXATTR promotion
> 
> the file include/linux/fs.h now defines struct fsxattr.
> 
> It defines FS_IOC_FSGETXATTR as well, so use that to wrap
> our local definition, and skip it if the kernel is providing
> it so that we don't get multiple definitions.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---
> 
> Should the kernel also #define HAVE_FSXATTR to help existing
> xfsprogs-devel installations?
> 
> (And what if headers are included in the other order?  Should
> we try to guard on the kernel side or no?)

I've already sent a patch to fix this - it was with the foreign
filesystem xfs_quota patch....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx