Re: [PATCH 6/6] xfs: rename XFS_BUF_ZEROFLAGS macro

[Dave Chinner <david@xxxxxxxxxxxxx>]

On Mon, Feb 08, 2016 at 01:12:36AM -0800, Christoph Hellwig wrote:
> Instead of just renaming it I'd rather dig deeper.
> 
> In xlog_bwrite we call xfs_bwrite, which already handles all flag
> clearing, so the call to XFS_BUF_ZEROFLAGS can just
> be removed.

Done.

> xlog_sync already sets a lot of these flags again, and is called on an
> iclog buffer which never has the READ or XBF_WRITE_FAIL set, so just
> replacing it with an opencoded
> 
>       bp->b_flags &= (XBF_FUA | XBF_FLUSH);

We can't do that because there are internal flags like _XBF_PAGES
that are set on log buffers. Clearing such flags will cause problems
when the iclog buffer is finally released on unmount. Hence I'd
prefer to keep the code as it stands.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx