| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 9/9] xfs: mode di_mode to vfs inode |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Tue, 9 Feb 2016 06:50:08 +1100 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20160208094239.GD4487@xxxxxxxxxxxxx> |
| References: | <1454905461-2773-1-git-send-email-david@xxxxxxxxxxxxx> <1454905461-2773-10-git-send-email-david@xxxxxxxxxxxxx> <20160208094239.GD4487@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Mon, Feb 08, 2016 at 01:42:39AM -0800, Christoph Hellwig wrote: > On Mon, Feb 08, 2016 at 03:24:21PM +1100, Dave Chinner wrote: > > - ASSERT(!(S_ISREG(ip->i_d.di_mode) && whichfork == XFS_DATA_FORK)); > > + ASSERT(!(S_ISREG(VFS_I(ip)->i_mode) && whichfork == XFS_DATA_FORK)); > > Maybe it's worth adding XFS_ISDIR/REG/.. helpers for all these checks? Makes sense - I think I'll do that as a followup patch, though, along with further icdinode cleanups. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 6/9] xfs: use vfs inode nlink field everywhere, Dave Chinner |
|---|---|
| Next by Date: | Re: [ANNOUNCE] xfs: for-next branch updated to 4a91310, Dave Chinner |
| Previous by Thread: | Re: [PATCH 9/9] xfs: mode di_mode to vfs inode, Christoph Hellwig |
| Next by Thread: | Re: [PATCH 9/9] xfs: mode di_mode to vfs inode, Brian Foster |
| Indexes: | [Date] [Thread] [Top] [All Lists] |