Re: [PATCH 6/9] xfs: use vfs inode nlink field everywhere

[Dave Chinner <david@xxxxxxxxxxxxx>]

On Mon, Feb 08, 2016 at 01:40:21AM -0800, Christoph Hellwig wrote:
> On Mon, Feb 08, 2016 at 03:24:18PM +1100, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > The Vfs tracks the inodenlink just like the xfs_icdinode. We can
> 
> s/Vfs/VFS/
> 
> > +STATIC int
> >  xfs_iunlink(
> > -   xfs_trans_t     *tp,
> > -   xfs_inode_t     *ip)
> > +   struct xfs_trans *tp,
> > +   struct xfs_inode *ip,
> > +   bool            ignore_linkcount)
> 
> I'd say kill the ignore_linkcount parameter and the assert depending on it.
> There are just two callers: xfs_droplink checks for i_nlink just before
> the call, and xfs_create_tmpfile has to set the override flag.

Will do, I think I added that when trying to track down a busy inodes
after unmount bug in this patch, and then never removed it again.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx