| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/9] xfs: introduce inode log format object |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Tue, 9 Feb 2016 06:28:23 +1100 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20160208092318.GA28146@xxxxxxxxxxxxx> |
| References: | <1454905461-2773-1-git-send-email-david@xxxxxxxxxxxxx> <1454905461-2773-2-git-send-email-david@xxxxxxxxxxxxx> <20160208092318.GA28146@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Mon, Feb 08, 2016 at 01:23:18AM -0800, Christoph Hellwig wrote: > This looks fine in general: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > > But: this now introduce struct inode to libxfs code, what's your plan > to deal with that in xfsprogs? The struct xfs_inode is already unique between user and kernel space, so I was simply going to define all the new fields directly inside the struct xfs_inode and: #define VFS_I(ip) (ip) Or If I can't get that to work without somehow defining a struct inode, then put all the fields in a struct inode private to the struct xfs_inode and just do the same conversion as the kernel. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| Previous by Date: | Re: [PATCH 2/2] dax: move writeback calls into the filesystems, Dan Williams |
|---|---|
| Next by Date: | Re: [PATCH 4/9] xfs: move v1 inode conversion to xfs_inode_from_disk, Dave Chinner |
| Previous by Thread: | Re: [PATCH 1/9] xfs: introduce inode log format object, Christoph Hellwig |
| Next by Thread: | [PATCH 2/9] xfs: remove timestamps from incore inode, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |