| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 9/9] xfs: mode di_mode to vfs inode |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Mon, 8 Feb 2016 01:42:39 -0800 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1454905461-2773-10-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1454905461-2773-1-git-send-email-david@xxxxxxxxxxxxx> <1454905461-2773-10-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.24 (2015-08-30) |
On Mon, Feb 08, 2016 at 03:24:21PM +1100, Dave Chinner wrote: > - ASSERT(!(S_ISREG(ip->i_d.di_mode) && whichfork == XFS_DATA_FORK)); > + ASSERT(!(S_ISREG(VFS_I(ip)->i_mode) && whichfork == XFS_DATA_FORK)); Maybe it's worth adding XFS_ISDIR/REG/.. helpers for all these checks? Otherwise looks fine: Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 8/9] xfs: move di_changecount to VFS inode, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH v8 6/9] dax: add support for fsync/msync, Jan Kara |
| Previous by Thread: | [PATCH 9/9] xfs: mode di_mode to vfs inode, Dave Chinner |
| Next by Thread: | Re: [PATCH 9/9] xfs: mode di_mode to vfs inode, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |