xfs
[Top] [All Lists]

Re: [PATCH 2/9] xfs: remove timestamps from incore inode

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/9] xfs: remove timestamps from incore inode
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 8 Feb 2016 01:28:17 -0800
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1454905461-2773-3-git-send-email-david@xxxxxxxxxxxxx>
References: <1454905461-2773-1-git-send-email-david@xxxxxxxxxxxxx> <1454905461-2773-3-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.24 (2015-08-30)
> +     /*
> +      * time is signed, so need to convert to signed 32 bit before
> +      * storing in inode timestamp which may be 64 bit. Otherwise
> +      * a time before epoch is converted to a time long after epoch
> +      * on 64 bit systems.
> +      */

Time should be captizalized at the beginning of the comment.

Otherwise looks fine:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>