xfs
[Top] [All Lists]

[PATCH 2/9] xfs: introduce metadata IO error class

To: xfs@xxxxxxxxxxx
Subject: [PATCH 2/9] xfs: introduce metadata IO error class
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 5 Feb 2016 12:23:20 +1100
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1454635407-22276-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1454635407-22276-1-git-send-email-david@xxxxxxxxxxxxx>
From: Dave Chinner <dchinner@xxxxxxxxxx>

Now we have the basic infrastructure, add the first error class so
we can build up the infrastructure in a meaningful way. Add the
metadata async write IO error class and sysfs entry, and introduce a
default configuration that matches the existing behaviour of
XFS_ERR_FAIL_NEVER for async write metadata buffers.

Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
---
 fs/xfs/xfs_mount.h |  3 +++
 fs/xfs/xfs_sysfs.c | 34 ++++++++++++++++++++++++++++++++++
 2 files changed, 37 insertions(+)

diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h
index 96c9658..36e7330 100644
--- a/fs/xfs/xfs_mount.h
+++ b/fs/xfs/xfs_mount.h
@@ -45,9 +45,11 @@ enum {
  * Failure types describe when an error is considered fatal.
  */
 enum {
+       XFS_ERR_METADATA,
        XFS_ERR_CLASS_MAX,
 };
 enum {
+       XFS_ERR_DEFAULT,
        XFS_ERR_ERRNO_MAX,
 };
 enum {
@@ -153,6 +155,7 @@ typedef struct xfs_mount {
                                                /* low free space thresholds */
        struct xfs_kobj         m_kobj;
        struct xfs_kobj         m_error_kobj;
+       struct xfs_kobj         m_error_meta_kobj;
        struct xfs_error_cfg    
m_error_cfg[XFS_ERR_CLASS_MAX][XFS_ERR_ERRNO_MAX];
        struct xstats           m_stats;        /* per-fs stats */
 
diff --git a/fs/xfs/xfs_sysfs.c b/fs/xfs/xfs_sysfs.c
index 7d81c1b..c5f0afa 100644
--- a/fs/xfs/xfs_sysfs.c
+++ b/fs/xfs/xfs_sysfs.c
@@ -344,11 +344,34 @@ int
 xfs_error_sysfs_init(
        struct xfs_mount        *mp)
 {
+       struct xfs_error_cfg    *cfg;
        int                     error;
 
        /* .../xfs/<dev>/error/ */
        error = xfs_sysfs_init(&mp->m_error_kobj, &xfs_error_ktype,
                                &mp->m_kobj, "error");
+       if (error)
+               return error;
+
+       /* .../xfs/<dev>/error/metadata/ */
+       error = xfs_sysfs_init(&mp->m_error_meta_kobj, &xfs_error_ktype,
+                               &mp->m_error_kobj, "metadata");
+       if (error)
+               goto out_error;
+
+       cfg = &mp->m_error_cfg[XFS_ERR_METADATA][XFS_ERR_DEFAULT];
+       error = xfs_sysfs_init(&cfg->kobj, &xfs_error_cfg_ktype,
+                               &mp->m_error_meta_kobj, "Default");
+       if (error)
+               goto out_error_meta;
+       cfg->fail_speed = XFS_ERR_FAIL_NEVER;
+
+       return 0;
+
+out_error_meta:
+       xfs_sysfs_del(&mp->m_error_meta_kobj);
+out_error:
+       xfs_sysfs_del(&mp->m_error_kobj);
        return error;
 }
 
@@ -356,5 +379,16 @@ void
 xfs_error_sysfs_del(
        struct xfs_mount        *mp)
 {
+       struct xfs_error_cfg    *cfg;
+       int                     i, j;
+
+       for (i = 0; i < XFS_ERR_CLASS_MAX; i++) {
+               for (j = 0; j < XFS_ERR_ERRNO_MAX; j++) {
+                       cfg = &mp->m_error_cfg[i][j];
+
+                       xfs_sysfs_del(&cfg->kobj);
+               }
+       }
+       xfs_sysfs_del(&mp->m_error_meta_kobj);
        xfs_sysfs_del(&mp->m_error_kobj);
 }
-- 
2.5.0

<Prev in Thread] Current Thread [Next in Thread>