On Mon, Feb 01, 2016 at 10:57:07AM +0100, Carlos Maiolino wrote:
> On Thu, Jan 28, 2016 at 11:36:55AM -0600, Eric Sandeen wrote:
> > On 1/28/16 10:57 AM, Carlos Maiolino wrote:
> > > xfs_disk_dquot_t *ddqp = &dqp->q_core;
> > >
> > > - /*
> > > - * The warnings and timers set the grace period given to
> > > - * a user or group before he or she can not perform any
> > > - * more writing. If it is zero, a default is used.
> > > - */
> >
> > Not sure why you removed this comment?
> >
> Regarding this comment, I think it's just redundant with the previous
> comment, I
> left it in the code for the V4 though, I believe Dave can rip it off if it is
> really redundant.
No, please don't ask me to do make random patch edits on commit -
it's your job as a patch submitter to get it right. I will sometimes
do this for simple patches or patches that come from a
never-seen-before-and-never-seen-again patch submitter, but for a
regular developer submitting non-trivial patches I won't change the
patches because the issue hasn't been sorted out during peer review.
Work it out with Eric, get a reviewed-by tag, and I'll apply it as
reviewed.
Cheers,
Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx
|