xfs
[Top] [All Lists]

Re: [PATCH 2/4] xfstests: require dedup ioctl support in 182

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH 2/4] xfstests: require dedup ioctl support in 182
From: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
Date: Thu, 28 Jan 2016 11:27:53 -0800
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1454001236-2600-3-git-send-email-hch@xxxxxx>
References: <1454001236-2600-1-git-send-email-hch@xxxxxx> <1454001236-2600-3-git-send-email-hch@xxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Jan 28, 2016 at 06:13:54PM +0100, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
>  tests/generic/182 | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/generic/182 b/tests/generic/182
> index bf5cd38..eb80b43 100755
> --- a/tests/generic/182
> +++ b/tests/generic/182
> @@ -46,6 +46,7 @@ _cleanup()
>  # real QA test starts here
>  _supported_os Linux
>  _require_test_reflink
> +_require_test_dedupe
>  _require_cp_reflink

The _require_*_reflink bits are unnecessary.  I must've been going too fast
when I wrote 181/182; I'll fix that in my repo and send patches.

Also 182's comments should s/reflink/dedupe/.

--D

>  
>  rm -f "$seqres.full"
> -- 
> 2.1.4
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

<Prev in Thread] Current Thread [Next in Thread>