xfs
[Top] [All Lists]

Re: [PATCH 6/8] xfs: move inode generation count to VFS inode

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 6/8] xfs: move inode generation count to VFS inode
From: Brian Foster <bfoster@xxxxxxxxxx>
Date: Mon, 25 Jan 2016 13:25:13 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1452751765-4420-7-git-send-email-david@xxxxxxxxxxxxx>
References: <1452751765-4420-1-git-send-email-david@xxxxxxxxxxxxx> <1452751765-4420-7-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.24 (2015-08-30)
On Thu, Jan 14, 2016 at 05:09:23PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Pull another 4 bytes out of the xfs_icdinode.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---
>  fs/xfs/libxfs/xfs_inode_buf.c | 8 ++++----
>  fs/xfs/libxfs/xfs_inode_buf.h | 1 -
>  fs/xfs/xfs_export.c           | 2 +-
>  fs/xfs/xfs_inode.c            | 5 +----
>  fs/xfs/xfs_inode_item.c       | 2 +-
>  fs/xfs/xfs_ioctl.c            | 2 +-
>  fs/xfs/xfs_iops.c             | 1 -
>  fs/xfs/xfs_itable.c           | 2 +-
>  8 files changed, 9 insertions(+), 14 deletions(-)
> 
...
> diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c
> index c424d4b..397ce85 100644
> --- a/fs/xfs/xfs_iops.c
> +++ b/fs/xfs/xfs_iops.c
> @@ -1227,7 +1227,6 @@ xfs_setup_inode(
>               break;
>       }
>  
> -     inode->i_generation = ip->i_d.di_gen;
>       i_size_write(inode, ip->i_d.di_size);
>       xfs_diflags_to_iflags(inode, ip);
>  

Same question here wrt to reclaimable inodes as the previous patch and
nlink..? Seems Ok otherwise.

Brian

> diff --git a/fs/xfs/xfs_itable.c b/fs/xfs/xfs_itable.c
> index cfb6527..6162e65 100644
> --- a/fs/xfs/xfs_itable.c
> +++ b/fs/xfs/xfs_itable.c
> @@ -100,11 +100,11 @@ xfs_bulkstat_one_int(
>       buf->bs_mtime.tv_nsec = inode->i_mtime.tv_nsec;
>       buf->bs_ctime.tv_sec = inode->i_ctime.tv_sec;
>       buf->bs_ctime.tv_nsec = inode->i_ctime.tv_nsec;
> +     buf->bs_gen = inode->i_generation;
>  
>       buf->bs_xflags = xfs_ip2xflags(ip);
>       buf->bs_extsize = dic->di_extsize << mp->m_sb.sb_blocklog;
>       buf->bs_extents = dic->di_nextents;
> -     buf->bs_gen = dic->di_gen;
>       memset(buf->bs_pad, 0, sizeof(buf->bs_pad));
>       buf->bs_dmevmask = dic->di_dmevmask;
>       buf->bs_dmstate = dic->di_dmstate;
> -- 
> 2.5.0
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

<Prev in Thread] Current Thread [Next in Thread>