Re: [PATCH 1/7] quota: remove unused cmd argument from quota_quotaon()

[Jan Kara <jack@xxxxxxx>]

On Fri 22-01-16 12:25:30, Eric Sandeen wrote:
> The cmd argument to quota_quotaon() via Q_QUOTAON quotactl
> is not used, so remove it.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Looks good. You can add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

                                                                Honza

> ---
>  fs/quota/quota.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/quota/quota.c b/fs/quota/quota.c
> index 3746367..ea66670 100644
> --- a/fs/quota/quota.c
> +++ b/fs/quota/quota.c
> @@ -79,7 +79,7 @@ unsigned int qtype_enforce_flag(int type)
>       return 0;
>  }
>  
> -static int quota_quotaon(struct super_block *sb, int type, int cmd, qid_t id,
> +static int quota_quotaon(struct super_block *sb, int type, qid_t id,
>                        struct path *path)
>  {
>       if (!sb->s_qcop->quota_on && !sb->s_qcop->quota_enable)
> @@ -659,7 +659,7 @@ static int do_quotactl(struct super_block *sb, int type, 
> int cmd, qid_t id,
>  
>       switch (cmd) {
>       case Q_QUOTAON:
> -             return quota_quotaon(sb, type, cmd, id, path);
> +             return quota_quotaon(sb, type, id, path);
>       case Q_QUOTAOFF:
>               return quota_quotaoff(sb, type);
>       case Q_GETFMT:
> -- 
> 1.7.1
> 
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR