xfs
[Top] [All Lists]

Re: [PATCH 6/6] Add configure check for members of dirent for use in io/

To: Felix Janda <felix.janda@xxxxxxxxx>
Subject: Re: [PATCH 6/6] Add configure check for members of dirent for use in io/readdir.c
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 14 Jan 2016 02:17:29 -0800
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20160113170938.GA10942@nyan>
References: <cover.1452627740.git.felix.janda@xxxxxxxxx> <20160112200022.GG568@nyan> <20160113075855.GG21939@xxxxxxxxxxxxx> <20160113170938.GA10942@nyan>
User-agent: Mutt/1.5.24 (2015-08-30)
On Wed, Jan 13, 2016 at 06:09:38PM +0100, Felix Janda wrote:
> Christoph Hellwig wrote:
> > I think we're having a deeper issue here.  For an LFS build we
> > absolutely should have these values as the kernel dirent64 has them.
> > 
> > Either we manage to not pull in the LFS version of readdir/getdents
> > or musl is doing something inredibly stupid.  Can you investigate if
> > and why we're not using the LFS getdents64 here?
> 
> With musl you always have LFS. However still musl does not define the
> _DIRENT_HAVE_*. You can see the full dirent.h at:
> 
> http://git.musl-libc.org/cgit/musl/tree/include/dirent.h
> 
> I will ask on the musl list whether these constants can be added. So
> you can disregard this patch.

Oh, ok.  That's a little weird, but I guess working around that
with a new autoconf test is fine.

<Prev in Thread] Current Thread [Next in Thread>