Re: [PATCH 6/6] Add configure check for members of dirent for use in io/readdir.c

[Felix Janda <felix.janda@xxxxxxxxx>]

Christoph Hellwig wrote:
> I think we're having a deeper issue here.  For an LFS build we
> absolutely should have these values as the kernel dirent64 has them.
> 
> Either we manage to not pull in the LFS version of readdir/getdents
> or musl is doing something inredibly stupid.  Can you investigate if
> and why we're not using the LFS getdents64 here?

With musl you always have LFS. However still musl does not define the
_DIRENT_HAVE_*. You can see the full dirent.h at:

http://git.musl-libc.org/cgit/musl/tree/include/dirent.h

I will ask on the musl list whether these constants can be added. So
you can disregard this patch.


However notice that these constants are not defined when not on linux
or with glibc, e.g. freebsd (without k). On these systems the code in
io/readdir.c just happens to have worked because either
dirent.d_namelen exists or nobody has tested it on these systems.

Felix