| To: | Felix Janda <felix.janda@xxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 6/6] Prefer stdint types over __uint*_t and __int*_t |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Wed, 13 Jan 2016 00:01:32 -0800 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20160112210849.GG10044@nyan> |
| References: | <cover.1452632647.git.felix.janda@xxxxxxxxx> <20160112210849.GG10044@nyan> |
| User-agent: | Mutt/1.5.24 (2015-08-30) |
> dmf_f_ctxt_t *dmf_f_ctxtp = (dmf_f_ctxt_t *)contextp;
> - __int64_t length;
> + int64_t length;
>
> if (bmap[0].bmv_entries <= 0) {
> return 1; /* caller must already be at EOF */
> diff --git a/doc/xfsdump.html b/doc/xfsdump.html
> index 9c6722e..f85128f 100644
> --- a/doc/xfsdump.html
> +++ b/doc/xfsdump.html
> @@ -1935,7 +1935,7 @@ The files are constructed like so:
> <pre>
> typedef struct invt_counter {
> INVT_COUNTER_FIELDS
> - __uint32_t ic_vernum;/* on disk version number for posterity */\
> + uint32_t ic_vernum;/* on disk version number for posterity */\
please keep the existing alignments for variable declarations or
structure members.
Otherwise this looks fine:
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
|
| Previous by Date: | Re: [PATCH 5/6] dump/var.c: Include <limits.h> for PATH_MAX, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH] Revert "xfs: clear PF_NOFREEZE for xfsaild kthread", Jiri Kosina |
| Previous by Thread: | [PATCH 6/6] Prefer stdint types over __uint*_t and __int*_t, Felix Janda |
| Next by Thread: | [PATCH v2] cleanup: Kill __[u]int*_t types, Felix Janda |
| Indexes: | [Date] [Thread] [Top] [All Lists] |