xfs
[Top] [All Lists]

Re: [PATCH 2/6] libxfs/linux.c: Replace use of ustat by stat

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/6] libxfs/linux.c: Replace use of ustat by stat
From: Felix Janda <felix.janda@xxxxxxxxx>
Date: Tue, 12 Jan 2016 22:33:22 +0100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20160112212454.GM10456@dastard>
References: <cover.1452627740.git.felix.janda@xxxxxxxxx> <20160112195945.GC568@nyan> <20160112212454.GM10456@dastard>
User-agent: Mutt/1.5.23 (2014-03-12)
Dave Chinner wrote:
> On Tue, Jan 12, 2016 at 08:59:45PM +0100, Felix Janda wrote:
> > ustat has been used to check whether a device file is mounted.
> > The function is deprecated and not supported by uclibc and musl.
> > Now do the check using the *mntent functions.
> 
> Which will cause problems with builds on other platforms.

This is the linux specific code...

>  Why not
> just use statfs() instead?

Since it does not have the functionality which ustat is used for.

Felix

<Prev in Thread] Current Thread [Next in Thread>